fix: Check proof block numbers re committed and proven tips#2275
Open
sergerad wants to merge 4 commits into
Open
fix: Check proof block numbers re committed and proven tips#2275sergerad wants to merge 4 commits into
sergerad wants to merge 4 commits into
Conversation
Collaborator
Author
|
@Mirko-von-Leipzig should we enable TLS for the streams by default and allow for a flag to disable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds block number checks to the
ProofSync::sync()andState::apply_proof()functions to ensure that:Adds an assert to
ProvenTipWriter::advance().Adds a stub verify block proof fn and uses it in
apply_proof().Adds a check for already validated transactions in
SubmitProvenTransactionhandler.Changelog